Vouch provided extensive testing is done beforehand to ensure a good balance between blocking malicious data and allowing non malicious data.

Anything "snapped" should be for good reason. Fleek would be best placed to go into any further detail on this.

I would need to check the items' nbt to ensure they are not malicious. I’ll write something to document what we can’t do with VP in the future.

Even though VulnerabilityPatcher is much better than "just block the feature", you are correct that it still outright clears a lot of things instead of selectively removing the danger that it has detected. There is definitely improvement possible in that area.

Quote

@SuperRyn#18793 VP (Vulnerbility Patcher) is a plugin that patches malicious nbt, such as bookbans.
But... it isn't used for just what it's name suggests.
It thanos snaps perfectly fine items if they have certain properties.

I have a quite few people messaging me with the same issue but I keep finding malicious NBT data - Obviously, it shouldn't wipe everything if it is in a container or any other data that is not malicious (the code checks if the item data is similar then wipe, but I think it does not include NBT, will need to debug to confirm the suspicion)

Quote

@SuperRyn#18793 -HP limiters
This is INCREDIBLY annoying, both for minigame design and also people who are stuck at more than 20 hp,
due to the admins disabling /attribute out of the blue.

We are planning to implement our own version of /attribute which will be the same as the vanilla version but disallowing non-admins to set others' attributes. If the health attribute is dangerous, then VP will remove the NBT data. I will check what level it determines dangerous.

Quote

@SuperRyn#18793 Imagine this: Someone has given you the best kit that exists in the game, before they leave the game for good.
But OOPS! it has a large amount of nbt which is far from harmless! VP sees it passing through the hopper, and it thanos snaps all NBT, including the nbt of other items inside the chest.
Very annoying!

See my first paragraph.

Quote

@SuperRyn#18793 VP has many other restrictions for item makers to get screwed up with.
VP should only be used to patch BOOKBANS. And bookbans EXCLUSIVELY.
Person using creative mode kill pots?
Just smite him! You shouldn't drain the fun from a server to streamline moderation.

VP patches many dangerous exploits, which is why TotalFreedom is still standing without being crashed every 5 minutes.

Quote

@SuperRyn#18793 tl;dr VP has unneeded restrictions, remove them.

Please clarify which restrictions are unneeded - I can investigate whether it's required to keep.

Quote

@StevenNL2000#18958 Even though VulnerabilityPatcher is much better than "just block the feature", you are correct that it still outright clears a lot of things instead of selectively removing the danger that it has detected. There is definitely improvement possible in that area.

Yeah, I haven't modified much with VP as it was originally created by CoolJWB - I have noticed few mistakes here and there. I will improve it when I have a chance to do so.

@"SuperRyn"#105 Are you able to provide any answers to the reply @"Fleek"#188 made above?