Posts by videogamesm12

  • Merge various toggle commands into /toggle

    To reduce the amount of bloat and unnecessary commands in the TotalFreedomMod, one idea I had was to merge most (if not all) of the toggle-related commands into the /toggle command. Examples of commands that would be moved include:

    • /gravity
    • /explosivearrows
    • /disguisetoggle
    • /togglediscord
    • /togglepickup
    • /toggleclownfish

    Operators would be able to use the /toggle command for the things they can toggle, but would not be able to access admin-level toggles such as lockdown or explosive arrows, as shown below:


    Operators:
    https://videogamesm12.me/b3vhocSDxb0B.png


    Admins:
    https://videogamesm12.me/m9rSGHdhelNU.png


    Note: Some commands wouldn't be moved because they actually have a reason to be separate (e.g. CommandSpy and PotionSpy).


    What do you think? Should this be implemented? Give your thoughts below.

  • Server Crash Reporting

    1. Server
    Freedom-01


    2. Date and time
    April 11, 2021 at 3:24 PM MDT


    3. Last command executed
    Shyrix: /orbit Shyrix stop


    4. Suspicious players
    None.


    5. Log file name
    2021-04-11-4.log.gz


    6. Notes
    Server locked up.

  • Show the remaining ban time on a ban

    Quote

    @elmon#14303 We could also just do both.

    Provided that it provides this information on the same line as the regular expiration date, sure why not.


    Here's an idea I had as for how we could modify it to accomplish this:

    Code
    Expires: 2021-04-20 12:00:00 MDT (9m 31s left)

  • Log all forms of punishments

    Quote

    @Ashaz#14298 Would anyone also support the idea of logging unbans too? In the Bottle0fWindex situation we still can't find out who unbanned him because TFM stopped logging.

    In a log file specifically for logging punishments, no. I feel that it wouldn't make sense. However, I do like the idea. Perhaps we could look into the idea of shifting the punishment log from a log all about punishments to an audit log of every administrative action.

    Quote

    @Ashaz#14298 Also, when TFM stops logging, does it stop logging punishments?

    No.

  • Show the remaining ban time on a ban

    @redeastwood#14295 Perhaps my crabby mood right now is impacting my judgment (I haven't slept yet). I agree that we should make their lives as easy as possible, but I feel that it's a bit excessive to add a new line containing information that could be viewed as redundant.

  • Log all forms of punishments

    According to the TotalFreedomMod's code, here's a proper list of punishments that are logged:

    • Bans (/tempban, /ban, and /tban)
    • Dooms
    • Kicks
    • Mutes
    • Smites

    Some punishments are indeed not logged, and this is likely the result of an oversight.


    Vouch.

  • Three bugs, two commands

    I've already written fixes for these commands, but haven't created a pull request just yet (waiting for pull request #43 to go through). This is to let the developers create a ticket without things becoming too confusing.


    Here are the three bugs I mentioned in this thread's title:

    • When doing /list -t, the command redundantly checks to see if the sender is admin twice. It accomplishes this by first checking the sender, then checking the player the sender represents. This results in a NullPointerException when attempting to execute the command from a non-player source (such as Telnet) as the sender does not represent a player from those sources:
      https://i.imgur.com/lGDALMK.png

    • Due to a fuck-up by a developer, /tempban is hardcoded to ban for 24 hours. This explains the inconsistent ban times as noted here: https://forum.totalfreedom.me/…heyre-banned-for-24-hours
      https://i.imgur.com/dncjeTZ.png

    • Using /tempban on a player who has joined in the past but isn't currently offline causes the plugin to throw a NullPointerException. This is because the getPlayer method returns null if a player isn't online. The command does verify this, but continues to try to call methods from the null player anyways. Here's the stacktrace: