Reactions duplicate the next minute after 2 people solve a reaction at the same time

CoolestGuy94 · November 6, 2022 at 6:47 PM

Date and Time (please include the timezone): nov 6 2022 @ 21:18:31 MSK (this is when we solved the reaction)

Describe the bug or exploit: When 2 people solve a reaction at the same time, this causes TFM to give them 10 coins as if this was one person, then the next reaction gets "duplicated" and second one being solvable. This causes servers to spam logs, as TFM doesnt know what to do with first reaction.

Plugin(s) impacted: Probably TFM

Expected behaviour (if known): Expected behaviour is unknown, but I would suggest 2 things to solve this : choose a random person to win a reaction, or make a tie-breaker reaction instead.

Step to reproduce:

Step 1: Wait for reaction to appear.

Step 2: Type it and enter at the same time another person does.
Step 3: Watch TFM shit it self and give 2 reactions instead of one

Server where the bug occurred: Freedom

Can the bug or exploit be reproduced on another server within the network? No

**videogamesm12** · November 6, 2022 at 9:28 PM Official Post

Could we look into shitcanning TFM's reaction system?

isaac · November 6, 2022 at 9:28 PM

pictures and logs

:[19:25:44 WARN]: Task #395781 for TotalFreedomMod v2022.06 generated an exceptionjava.lang.NullPointerException: Cannot invoke "org.bukkit.boss.BossBar.setProgress(double)" because "this.this$0.countdownBar" is null at http://TotalFreedomMod.jar//me.totalfreedom.totalfreedommod.shop.Shop$2.run(Shop.java:106) at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftTask.run(CraftTask.java:101) at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:483) at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1567) at net.minecraft.server.dedicated.DedicatedServer.b(DedicatedServer.java:498) at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:1483) at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1282) at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) at http://java.base/java.lang.Thread.run(Thread.java:833)

caused by:

**videogamesm12** · November 6, 2022 at 9:29 PM Official Post

Quote from isaac

pictures and logs
:[19:25:44 WARN]: Task #395781 for TotalFreedomMod v2022.06 generated an exceptionjava.lang.NullPointerException: Cannot invoke "org.bukkit.boss.BossBar.setProgress(double)" because "this.this$0.countdownBar" is null at http://TotalFreedomMod.jar//me.totalfreedom.totalfreedommod.shop.Shop$2.run(Shop.java:106) at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftTask.run(CraftTask.java:101) at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:483) at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1567) at net.minecraft.server.dedicated.DedicatedServer.b(DedicatedServer.java:498) at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:1483) at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1282) at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) at http://java.base/java.lang.Thread.run(Thread.java:833)
caused by:

Reboot the server as a temporary measure.

characterslimits · November 6, 2022 at 9:33 PM

Quote from videogamesm12

Could we look into shitcanning TFM's reaction system?

Then, how are players supposed to get coins?

erin · November 6, 2022 at 9:40 PM

Quote from videogamesm12

Could we look into shitcanning TFM's reaction system?

No, it should remain in some way. It's actually used by many players as some light competition and to get coins.

**videogamesm12** · November 6, 2022 at 9:47 PM Official Post

Quote from characterslimits

Quote from videogamesm12

Could we look into shitcanning TFM's reaction system?

Then, how are players supposed to get coins?

Quote from erin

Quote from videogamesm12

Could we look into shitcanning TFM's reaction system?

No, it should remain in some way. It's actually used by many players as some light competition and to get coins.

Then it should be replaced with whatever reactions plugin that the TotalFreedomMod was trying to replace.