is there a way to make this shorter

darwin · January 15, 2022 at 12:13 PM

maybe im just dumb but i cant seem to figure out how to make a calculator

Python

# import math modules  
from math import sin,cos,tan,radians  

# loop so that continue actually works  
while True:  
  # asks for function for the first value  
  FUNCTION1 = input("Enter function for the first number (optional): ")  

  # prevents invalid functions from being inserted  
  if not FUNCTION1:  
    print("INFO - NO FUNCTION")  
    print("no function inserted")  
    print("skipping")  
  if FUNCTION1 != 'sin' and FUNCTION1 != 'cos' and FUNCTION1 != 'tan' and FUNCTION1 != 'radians':  
    print("ERROR - INVALID OPERATION")  
    print("function is not valid")  
    continue  

  # asks for the first value  
  FLOAT1 = input("Enter first number: ")  

  # prevents invalid values from being inserted  
  if not FLOAT1:  
    print("ERROR - INVALID OPERATION")  
    print("no value inserted")  
    continue  
  try:  
    float(FLOAT1)  
  except:  
    print("ERROR - INVALID OPERATION")  
    print("value is not a valid number")  
    continue  

  # asks for the operand  
  OPERAND = input("Enter operand: ")  

  # prevents invalid operands from being inserted  
  #  
  if not OPERAND:  
    print("ERROR - INVALID OPERATION")  
    print("no operand inserted")  
    continue  
  if OPERAND != '+' and OPERAND != '-' and OPERAND != '*' and OPERAND != '/':  
    print("ERROR - INVALID OPERATION")  
    print("invalid operand")  
    continue    

  # asks for function of the second value  
  FUNCTION2 = input("Enter function for the second number (optional): ")  

  # prevents invalid FUNCTIONs from being inserted  
  if not FUNCTION2:  
    print("INFO - NO FUNCTION")  
    print("no function inserted")  
    print("skipping")  
  if FUNCTION2 != 'sin' and FUNCTION2 != 'cos' and FUNCTION2 != 'tan' and FUNCTION2 != 'radians':  
    print("ERROR - INVALID OPERATION")  
    print("function is not valid")  
    continue  

  # asks for the second value  
  FLOAT2 = input("Enter second number: ")  

  # prevents invalid values from being inserted  
  if not FLOAT2:  
    print("ERROR - INVALID OPERATION")  
    print("no value inserted")  
    continue  
  try:  
    float(FLOAT2)  
  except:  
    print("ERROR - INVALID OPERATION")  
    print("value is not a valid number")  
    continue  

  # actually does some math  
  #  
  if OPERAND == "+":  
    if FUNCTION1 == "tan":  
      if FUNCTION2 == "tan":  
        print(tan(float(FLOAT1)) + tan(float(FLOAT2)))  
      elif FUNCTION2 == "sin":  
        print(tan(float(FLOAT1)) + sin(float(FLOAT2)))  
      elif FUNCTION2 == "cos":  
        print(tan(float(FLOAT1)) + cos(float(FLOAT1)))  
      elif FUNCTION2 == "radians":  
        print(tan(float(FLOAT1) + radians(float(FLOAT2))))  
    elif FUNCTION1 == "sin":  
      if FUNCTION2 == "tan":  
        print(sin(float(FLOAT1)) + tan(float(FLOAT2)))  
      elif FUNCTION2 == "sin":  
        print(sin(float(FLOAT1)) + sin(float(FLOAT2)))  
      elif FUNCTION2 == "cos":  
        print(sin(float(FLOAT1)) + cos(float(FLOAT2)))  
      elif FUNCTION2 == "radians":  
        print(sin(float(FLOAT1)) + radians(float(FLOAT2)))  
    elif FUNCTION1 == "cos":  
      if FUNCTION2 == "tan":  
        print(cos(float(FLOAT1)) + tan(float(FLOAT2)))  
      elif FUNCTION2 == "sin":   
        print(cos(float(FLOAT1)) + sin(float(FLOAT2)))  
      elif FUNCTION2 == "cos":  
        print(cos(float(FLOAT1)) + cos(float(FLOAT2)))  
      elif FUNCTION2 == "radians":  
        print(cos(float(FLOAT1)) + radians(float(FLOAT2)))  
      elif not FUNCTION2:  
        print(cos(float(FLOAT1)) + float(FLOAT2))  
    elif FUNCTION1 == "radians":  
      if FUNCTION2 == "tan":  
        print(radians(float(FLOAT1)) + tan(float(FLOAT2)))  
      elif FUNCTION2 == "sin":  
        print(radians(float(FLOAT1)) + sin(float(FLOAT2)))  
      elif FUNCTION2 == "cos":  
        print(radians(float(FLOAT1)) + cos(float(FLOAT2)))  
      elif FUNCTION2 == "radians":  
        print(radians(float(FLOAT1)) + radians(float(FLOAT2)))  
      elif not FUNCTION2:  
        print(radians(float(FLOAT1)) + float(FLOAT2))  
    elif not FUNCTION1:  
      if FUNCTION2 == "tan":  
        print(float(FLOAT1) + tan(float(FLOAT2)))  
      elif FUNCTION2 == "sin":  
        print(float(FLOAT1) + sin(float(FLOAT2)))  
      elif FUNCTION2 == "cos":  
        print(float(FUNCTION1) + cos(float(FLOAT2)))  
      elif FUNCTION2 == "radians":  
        print(float(FLOAT1) + radians(float(FLOAT2)))  
      elif not FUNCTION2:  
        print(float(FLOAT1) + float(FLOAT2))  
  elif OPERAND == "-":  
    if FUNCTION1 == "tan":  
      if FUNCTION2 == "tan":  
        print(tan(float(FLOAT1)) - tan(float(FLOAT2)))  
      elif FUNCTION2 == "sin":  
        print(tan(float(FLOAT1)) - sin(float(FLOAT2)))  
      elif FUNCTION2 == "cos":  
        print(tan(float(FLOAT1)) - cos(float(FLOAT1)))  
      elif FUNCTION2 == "radians":  
        print(tan(float(FLOAT1) - radians(float(FLOAT2))))  
    elif FUNCTION1 == "sin":  
      if FUNCTION2 == "tan":  
          print(sin(float(FLOAT1)) - tan(float(FLOAT2)))  
      elif FUNCTION2 == "sin":  
          print(sin(float(FLOAT1)) - sin(float(FLOAT2)))  
      elif FUNCTION2 == "cos":  
        print(sin(float(FLOAT1)) - cos(float(FLOAT2)))  
      elif FUNCTION2 == "radians":  
        print(sin(float(FLOAT1)) - radians(float(FLOAT2)))  
      elif FUNCTION1 == "cos":  
       if FUNCTION2 == "tan":  
         print(cos(float(FLOAT1)) - tan(float(FLOAT2)))  
       elif FUNCTION2 == "sin":   
         print(cos(float(FLOAT1)) - sin(float(FLOAT2)))  
       elif FUNCTION2 == "cos":  
         print(cos(float(FLOAT1)) - cos(float(FLOAT2)))  
      elif FUNCTION2 == "radians":  
         print(cos(float(FLOAT1)) - radians(float(FLOAT2)))  
      elif not FUNCTION2:  
         print(cos(float(FLOAT1)) - float(FLOAT2))  
    elif FUNCTION1 == "radians":  
       if FUNCTION2 == "tan":  
         print(radians(float(FLOAT1)) - tan(float(FLOAT2)))  
       elif FUNCTION2 == "sin":  
         print(radians(float(FLOAT1)) - sin(float(FLOAT2)))  
       elif FUNCTION2 == "cos":  
         print(radians(float(FLOAT1)) - cos(float(FLOAT2)))  
       elif FUNCTION2 == "radians":  
         print(radians(float(FLOAT1)) - radians(float(FLOAT2)))  
       elif not FUNCTION2:  
         print(radians(float(FLOAT1)) - float(FLOAT2))  
    elif not FUNCTION1:  
      if FUNCTION2 == "tan":  
        print(float(FLOAT1) - tan(float(FLOAT2)))  
      elif FUNCTION2 == "sin":  
        print(float(FLOAT1) - sin(float(FLOAT2)))  
      elif FUNCTION2 == "cos":  
        print(float(FUNCTION1) - cos(float(FLOAT2)))  
      elif FUNCTION2 == "radians":  
        print(float(FLOAT1) - radians(float(FLOAT2)))  
      elif not FUNCTION2:  
        print(float(FLOAT1) - float(FLOAT2))  
  elif OPERAND == "*":  
    if FUNCTION1 == "tan":  
      if FUNCTION2 == "tan":  
        print(tan(float(FLOAT1)) * tan(float(FLOAT2)))  
      elif FUNCTION2 == "sin":  
        print(tan(float(FLOAT1)) * sin(float(FLOAT2)))  
      elif FUNCTION2 == "cos":  
        print(tan(float(FLOAT1)) * cos(float(FLOAT1)))  
      elif FUNCTION2 == "radians":  
        print(tan(float(FLOAT1) * radians(float(FLOAT2))))  
    elif FUNCTION1 == "sin":  
      if FUNCTION2 == "tan":  
        print(sin(float(FLOAT1)) * tan(float(FLOAT2)))  
      elif FUNCTION2 == "sin":  
        print(sin(float(FLOAT1)) * sin(float(FLOAT2)))  
      elif FUNCTION2 == "cos":  
        print(sin(float(FLOAT1)) * cos(float(FLOAT2)))  
      elif FUNCTION2 == "radians":  
        print(sin(float(FLOAT1)) * radians(float(FLOAT2)))  
      elif FUNCTION1 == "cos":  
        if FUNCTION2 == "tan":  
          print(cos(float(FLOAT1)) * tan(float(FLOAT2)))  
        elif FUNCTION2 == "sin":   
          print(cos(float(FLOAT1)) * sin(float(FLOAT2)))  
        elif FUNCTION2 == "cos":  
          print(cos(float(FLOAT1)) * cos(float(FLOAT2)))  
      elif FUNCTION2 == "radians":  
        print(cos(float(FLOAT1)) * radians(float(FLOAT2)))  
      elif not FUNCTION2:  
        print(cos(float(FLOAT1)) * float(FLOAT2))  
      elif FUNCTION1 == "radians":  
        if FUNCTION2 == "tan":  
          print(radians(float(FLOAT1)) * tan(float(FLOAT2)))  
        elif FUNCTION2 == "sin":  
          print(radians(float(FLOAT1)) * sin(float(FLOAT2)))  
        elif FUNCTION2 == "cos":  
          print(radians(float(FLOAT1)) * cos(float(FLOAT2)))  
        elif FUNCTION2 == "radians":  
          print(radians(float(FLOAT1)) * radians(float(FLOAT2)))  
        elif not FUNCTION2:  
          print(radians(float(FLOAT1)) * float(FLOAT2))  
      elif not FUNCTION1:  
        if FUNCTION2 == "tan":  
          print(float(FLOAT1) * tan(float(FLOAT2)))  
        elif FUNCTION2 == "sin":  
          print(float(FLOAT1) * sin(float(FLOAT2)))  
        elif FUNCTION2 == "cos":  
          print(float(FUNCTION1) * cos(float(FLOAT2)))  
        elif FUNCTION2 == "radians":  
          print(float(FLOAT1) * radians(float(FLOAT2)))  
        elif not FUNCTION2:  
          print(float(FLOAT1) * float(FLOAT2))  
  elif OPERAND == "/":  
    if FUNCTION1 == "tan":  
      if FUNCTION2 == "tan":  
        print(tan(float(FLOAT1)) / tan(float(FLOAT2)))  
      elif FUNCTION2 == "sin":  
        print(tan(float(FLOAT1)) / sin(float(FLOAT2)))  
      elif FUNCTION2 == "cos":  
        print(tan(float(FLOAT1)) / cos(float(FLOAT1)))  
      elif FUNCTION2 == "radians":  
        print(tan(float(FLOAT1) / radians(float(FLOAT2))))  
    elif FUNCTION1 == "sin":  
      if FUNCTION2 == "tan":  
        print(sin(float(FLOAT1)) / tan(float(FLOAT2)))  
      elif FUNCTION2 == "sin":  
        print(sin(float(FLOAT1)) / sin(float(FLOAT2)))  
      elif FUNCTION2 == "cos":  
        print(sin(float(FLOAT1)) / cos(float(FLOAT2)))  
      elif FUNCTION2 == "radians":  
        print(sin(float(FLOAT1)) / radians(float(FLOAT2)))  
      elif FUNCTION1 == "cos":  
        if FUNCTION2 == "tan":  
          print(cos(float(FLOAT1)) / tan(float(FLOAT2)))  
        elif FUNCTION2 == "sin":   
          print(cos(float(FLOAT1)) / sin(float(FLOAT2)))  
        elif FUNCTION2 == "cos":  
          print(cos(float(FLOAT1)) / cos(float(FLOAT2)))  
        elif FUNCTION2 == "radians":  
          print(cos(float(FLOAT1)) / radians(float(FLOAT2)))  
        elif not FUNCTION2:  
          print(cos(float(FLOAT1)) / float(FLOAT2))  
    elif FUNCTION1 == "radians":  
       if FUNCTION2 == "tan":  
        print(radians(float(FLOAT1)) / tan(float(FLOAT2)))  
       elif FUNCTION2 == "sin":  
        print(radians(float(FLOAT1)) / sin(float(FLOAT2)))  
       elif FUNCTION2 == "cos":  
        print(radians(float(FLOAT1)) / cos(float(FLOAT2)))  
       elif FUNCTION2 == "radians":  
        print(radians(float(FLOAT1)) / radians(float(FLOAT2)))  
       elif not FUNCTION2:  
        print(radians(float(FLOAT1)) / float(FLOAT2))  
    elif not FUNCTION1:  
      if FUNCTION2 == "tan":  
        print(float(FLOAT1) / tan(float(FLOAT2)))  
      elif FUNCTION2 == "sin":  
        print(float(FLOAT1) / sin(float(FLOAT2)))  
      elif FUNCTION2 == "cos":  
        print(float(FUNCTION1) / cos(float(FLOAT2)))  
      elif FUNCTION2 == "radians":  
        print(float(FLOAT1) / radians(float(FLOAT2)))  
      elif not FUNCTION2:  
        print(float(FLOAT1) / float(FLOAT2))  
  else:  
    print("ERROR - INVALID OPERATION")  
    print("unknown error")  
    continue

Display More

RandomCommentator · January 16, 2022 at 12:50 PM

so many elif's i almost died while trying to read this

Tizz · January 16, 2022 at 1:22 PM

What language is that? (Looks like Python but I haven't studied it.) You should edit your post to include it after the opening backquotes for correct syntax highlighting, e.g. ```python

square · January 16, 2022 at 3:09 PM

https://www.toptal.com/developers/hastebin/oxeliyuxiv.lua

this is my solution, just did it quick so don't criticise it harshly lol

edit: tf forums screws up me putting it in a block so i put it in hastebin

edit: forgot to add verification to check that the function is of length 5 so if you want to copy and paste it be careful of that

darwin · January 16, 2022 at 3:57 PM

okay, i guess its just me not being able to solve problems the simple way

is there a way to make this shorter

wild1145 July 16, 2022 at 11:50 PM

Users Viewing This Thread