Silent flag for /gtfo (-q) doesn't message the sender - Bug Report

Alco_Rs11 · Dec 16th 2021

This is weird.

Date and Time (please include the timezone):

Describe the bug or exploit: When you run /gtfo -q, it should be expected that the sender of the command be displayed a message that the player was banned successfully. This is not the case. I included a video showing what happened when I banned a griefer with this flag. Unless you verify they're banned via the punishment log, you cannot tell if someone is actually banned if done silently.
https://cdn.discordapp.com/att…7380226088/zbjuahOtHj.mp4

Code

:[03:32:21 INFO]: [Discord] Ael [Admin]: what's the argument for a quiet ban?  
:[03:32:26 INFO]: Alco_Rs11 issued server command: /gtfo  
:[03:32:31 INFO]: Alco_Rs11 issued server command: /o i think -q  
:[03:32:31 INFO]: [ADMIN] Alco_Rs11 [Admin]: i think -q  
:[03:32:51 INFO]: Aeluraydak issued server command: /ban Benjifrog757 grief - ael -q  
:[03:32:58 INFO]: Alco_Rs11 issued server command: /o did it work  
:[03:32:58 INFO]: [ADMIN] Alco_Rs11 [Admin]: did it work  
:[03:33:05 INFO]: Aeluraydak issued server command: /o i don't know  
:[03:33:05 INFO]: [ADMIN] Aeluraydak [Admin]: i don't know  
:[03:33:09 INFO]: Aeluraydak issued server command: /o didn't show anything  
:[03:33:09 INFO]: [ADMIN] Aeluraydak [Admin]: didn't show anything

Display More

Plugin(s) impacted: TotalFreedomMod
Expected behaviour (if known): Banning a player silently should inform the sender that they were banned successfully along with displaying the ban reason they set.
Step to reproduce: Ban a player using the -q flag, no response will be displayed to the sender (you.) informing that the player has been banned with X reason (if applicable).
Server where the bug occurred: Freedom-01
Can the bug or exploit be reproduced on another server within the network? No, since this is only a TFM problem.

Fleek · Dec 16th 2021

@"Alco_Rs11"#91 Did you check the console for any errors? The code shows that the sender should receive Banned X quietly. - See https://github.com/AtlasMediaG…and/Command_ban.java#L121

Tizz · Dec 16th 2021

↩ Fleek Will check at home but looks like the syntax is msg(recipient, message) while in the row you selected the recipient argument (which should be sender) is missing.

Alco_Rs11 · Dec 16th 2021

↩ Fleek no errors occured when I did it nor when Ael did it. I had telnet open which is where I got the logs where Ael ran it and wondered why no message showed.

**videogamesm12** · Dec 16th 2021

I see the problem - Alco is performing a quiet ban on a player who is offline. The code that's supposed to send the message only executes if the target player is currently online. This is definitely an oversight that should be addressed.
https://github.com/AtlasMediaG…Command_ban.java#L66-L125

Java

final Player player = getPlayer(args[0]);  
if (player == null)  
{  
    // Gets the IP using Essentials data if available  
    if (plugin.esb.isEnabled() && plugin.esb.getEssentialsUser(args[0]) != null)  
    {  
        User essUser = plugin.esb.getEssentialsUser(args[0]);  
        //  
        username = essUser.getName();  
        ip = essUser.getLastLoginAddress();  
    }  
    // Last resort - Getting the first result from the username itself  
    else  
    {  
        PlayerData entry = plugin.pl.getData(args[0]);  
        if (entry == null)  
        {  
            msg(PLAYER_NOT_FOUND);  
            return true;  
        }  
        else  
        {  
            username = entry.getName();  
            ip = entry.getIps().get(0);  
        }  
    }  
}  
else  
{  
    username = player.getName();  
    ip = FUtil.getIp(player);  

    // Deop  
    player.setOp(false);  

    // Gamemode survival  
    player.setGameMode(GameMode.SURVIVAL);  

    // Clear inventory  
    player.getInventory().clear();  

    if (!silent)  
    {  
        // Strike with lightning  
        final Location targetPos = player.getLocation();  
        for (int x = -1; x <= 1; x++)  
        {  
            for (int z = -1; z <= 1; z++)  
            {  
                final Location strike_pos = new Location(targetPos.getWorld(), targetPos.getBlockX() + x, targetPos.getBlockY(), targetPos.getBlockZ() + z);  
                Objects.requireNonNull(targetPos.getWorld()).strikeLightning(strike_pos);  
            }  
        }  
    }  
    else  
    {  
        msg("Banned " + player.getName() + " quietly.");  
    }  
    // Kill player  
    player.setHealth(0.0);  
}

Display More

Silent flag for /gtfo (-q) doesn't message the sender - Bug Report

wild1145 Jul 17th 2022

Participate now!

Share