Allow ops to change skin

CoreProtect logs blocks as the disguised player, not the original player. Would make framing people a command away.

Instead of using LibsDisguises, can we not just re-use SkinsRestorer? I still don't understand why it was removed in the first place.

@Shdwo#13563 The only reason we had it was because at the time we were a cracked server. This is no longer the case, so it was removed after it was deemed irrelevant.

@videogamesm12#13564 So there's no known issues with it? In which case it would be perfect for this suggestion.

SkinsRestorer actually did let you change skins but it's gone now because we're in online mode. I would actually advise against adding it because it is a performance hog. You should modify libsdisguises to not change the players actual name

Quote

@videogamesm12#13564 This is no longer the case, so it was removed after it was deemed irrelevant.

not true, we had it for quite a while after turning into a premium server, however we realized that it was causing mass server lag, and thus we removed it. If someone can find a substitute plugin, we could see if that might work

@Telesphoreo#13577 I'd also agree on that. make sure the real player name doesn't change and bam, "player" disguises.
I miss being able to swim on the air.

I'm not really happy with modifying LibsDisguise, especially any more than the bare essentials require us to. Can anyone think of any other better options or alternate plugins to look into?

@wild1145#15396 We already use a modified version of LibsDisguises anyways, so pretty sure we can implement something into the plugin in that does this pretty easily.

@videogamesm12#15423 I'd rather us not be modifying it in the first place, and the more we modify it, the less manageable it becomes especially for MC Version upgrades... That's currently my concern. I'd like to try where possible to keep modifications of plugins to a minimum.

I've raised FS-268 to look into if we do actively need to maintain our own clone of LibsDisguises and if so to scope the exact work required to make this happen. I'll mark it as approved but with the understanding that this is only really approved to investigate.